Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename table name in table_kv based wal #868

Merged
merged 1 commit into from
May 6, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented May 5, 2023

Which issue does this PR close?

Closes #

Rationale for this change

The wal related table name in table_kv based wal is strange.

What changes are included in this PR?

Rename related tables names.

Are there any user-facing changes?

BREAKING CHANGE, users using obkv based wal will lose the wal data.

How does this change test

Test by ut.

@Rachelint Rachelint changed the title chore rename table name in table_kv based wal chore: rename table name in table_kv based wal May 5, 2023
@Rachelint Rachelint force-pushed the rename-wal-table-name branch 2 times, most recently from 5720e7c to 346ccf3 Compare May 5, 2023 11:11
@Rachelint Rachelint changed the title chore: rename table name in table_kv based wal chore!: rename table name in table_kv based wal May 6, 2023
BREAKING CHANGE: incompatible with the old wal data(obkv based) due to different tables names.
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 4a73fac into apache:main May 6, 2023
ShiKaiWi added a commit that referenced this pull request May 8, 2023
ShiKaiWi added a commit that referenced this pull request May 8, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
BREAKING CHANGE: incompatible with the old wal data(obkv based) due to different tables names.
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@Rachelint Rachelint deleted the rename-wal-table-name branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants