Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward request in grpc write #844

Merged
merged 6 commits into from
Apr 20, 2023
Merged

feat: forward request in grpc write #844

merged 6 commits into from
Apr 20, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Apr 17, 2023

Which issue does this PR close?

Closes #820

Rationale for this change

Support forwarding write requests to the actual data node.

What changes are included in this PR?

  • Split write requests according to the actual write addresses.
  • When the endpoint does not exist, the route interface return routing information with None(endpoint).

Are there any user-facing changes?

When show create of a partition table, the table options will use the options of the first partition sub-table.

How does this change test

Manual testing and CI.

@chunshao90 chunshao90 marked this pull request as ready for review April 18, 2023 03:39
server/src/proxy/forward.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
router/src/cluster_based.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Apr 20, 2023
Merged via the queue into apache:main with commit b4fffd6 Apr 20, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: forward request in grpc write

* refactor code

* refactor by CR

* refactor by CR

* chore: address CR

* chore: disable cluster integration test

---------

Co-authored-by: xikai.wxk <xikai.wxk@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl show create table of partition table
2 participants