-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: forward request in grpc write #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
reviewed
Apr 18, 2023
ShiKaiWi
reviewed
Apr 18, 2023
ShiKaiWi
reviewed
Apr 18, 2023
ShiKaiWi
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chunshao90
added a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: forward request in grpc write * refactor code * refactor by CR * refactor by CR * chore: address CR * chore: disable cluster integration test --------- Co-authored-by: xikai.wxk <xikai.wxk@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #820
Rationale for this change
Support forwarding write requests to the actual data node.
What changes are included in this PR?
Are there any user-facing changes?
When
show create
of apartition table
, the table options will use the options of the first partition sub-table.How does this change test
Manual testing and CI.