Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install dev dependencies in make file #815

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Which issue does this PR close?

Closes #529

Rationale for this change

see #529

What changes are included in this PR?

Add a new target make dev-setup in make file to install dev dependencies.

Are there any user-facing changes?

User can execute command make dev-setup to install dev dependencies.

How does this change test

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review April 11, 2023 08:11
Copy link
Contributor

@archerny archerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved
@MichaelLeeHZ MichaelLeeHZ added this pull request to the merge queue Apr 11, 2023
Merged via the queue into apache:main with commit a38cdc0 Apr 11, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* install dev dependencies in make file

* apt install -y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add new a target make dev-setup to install dependencies
3 participants