Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl getTableInfo in remoteEngine service #793

Merged
merged 2 commits into from
Mar 30, 2023
Merged

feat: impl getTableInfo in remoteEngine service #793

merged 2 commits into from
Mar 30, 2023

Conversation

chunshao90
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

The schema of partition table will be obtained from the first sub-table, so a remote engine is needed to implement the table information access interface.

What changes are included in this PR?

Impl getTableInfo in remoteEngine service.

Are there any user-facing changes?

No.

How does this change test

Testing will be conducted with the partition table, and it will be used internally by the engine without affecting external users for the time being.

common_types/src/schema.rs Outdated Show resolved Hide resolved
server/src/grpc/remote_engine_service/mod.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #793 (b9b2f5d) into main (72f1701) will decrease coverage by 0.16%.
The diff coverage is 3.31%.

❗ Current head b9b2f5d differs from pull request most recent head 3188022. Consider uploading reports for the commit 3188022 to get more accurate results

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   68.28%   68.13%   -0.16%     
==========================================
  Files         295      295              
  Lines       46695    46817     +122     
==========================================
+ Hits        31886    31898      +12     
- Misses      14809    14919     +110     
Impacted Files Coverage Δ
common_types/src/schema.rs 96.50% <ø> (ø)
interpreters/src/show.rs 28.67% <0.00%> (-3.12%) ⬇️
server/src/grpc/metrics.rs 0.00% <0.00%> (ø)
server/src/grpc/remote_engine_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/proxy/grpc/write.rs 34.38% <0.00%> (-0.39%) ⬇️
sql/src/influxql/planner.rs 51.00% <0.00%> (-4.44%) ⬇️
table_engine/src/remote/model.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 69.44% <100.00%> (+0.08%) ⬆️
sql/src/plan.rs 93.93% <100.00%> (+0.18%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ShiKaiWi ShiKaiWi enabled auto-merge March 30, 2023 09:58
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 30, 2023
Merged via the queue into apache:main with commit 37d8746 Mar 30, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: impl getTableInfo in remoteEngine service

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants