Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump datafusion, add influxql aggregator support #778

Merged
merged 13 commits into from
Apr 6, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 27, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Currently only raw query is supported, aggregator is next step for influxql support.

What changes are included in this PR?

Are there any user-facing changes?

Yes, influxql aggregator is supported now.

How does this change test

CI

@jiacai2050 jiacai2050 marked this pull request as ready for review April 4, 2023 03:51
@jiacai2050 jiacai2050 changed the title refactor: bump datafusion to latest refactor: bump datafusion, add influxql aggregator support Apr 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #778 (0dfff37) into main (c083f51) will decrease coverage by 0.21%.
The diff coverage is 20.33%.

❗ Current head 0dfff37 differs from pull request most recent head b25eb9c. Consider uploading reports for the commit b25eb9c to get more accurate results

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   68.16%   67.96%   -0.21%     
==========================================
  Files         295      294       -1     
  Lines       46873    46561     -312     
==========================================
- Hits        31951    31644     -307     
+ Misses      14922    14917       -5     
Impacted Files Coverage Δ
analytic_engine/src/instance/open.rs 80.69% <ø> (-0.06%) ⬇️
analytic_engine/src/manifest/details.rs 95.63% <ø> (-0.03%) ⬇️
catalog/src/schema.rs 78.26% <ø> (-0.91%) ⬇️
catalog_impls/src/table_based.rs 83.10% <ø> (-0.36%) ⬇️
common_types/src/record_batch.rs 90.65% <0.00%> (-0.70%) ⬇️
components/arrow_ext/src/ipc.rs 95.15% <ø> (ø)
interpreters/src/show.rs 28.67% <0.00%> (ø)
...nterpreters/src/table_manipulator/catalog_based.rs 97.19% <ø> (-0.96%) ⬇️
.../df_planner_extension/table_scan_by_primary_key.rs 20.61% <0.00%> (-2.92%) ⬇️
server/src/grpc/meta_event_service/mod.rs 0.00% <ø> (ø)
... and 21 more

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sql/src/influxql/planner.rs Show resolved Hide resolved
sql/src/influxql/planner.rs Show resolved Hide resolved
sql/src/influxql/planner.rs Show resolved Hide resolved
sql/src/frontend.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Apr 6, 2023
Merged via the queue into apache:main with commit f5af256 Apr 6, 2023
@jiacai2050 jiacai2050 deleted the bump-df branch May 15, 2023 04:11
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* bump datafusion to latest

* fix Predicate

* bump sql parser

* pass all tables when build influxql plan

* convert schema to influxql

* bump influxql

* remove unwrap

* fix ut

* fix integration tests

* fix dyn_hash

* add integration test

* add comments

* fix CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants