Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify the logs in query path (#770) #776

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: simplify the logs in query path (#770) #776

merged 1 commit into from
Mar 28, 2023

Conversation

zouxiang1993
Copy link
Contributor

@zouxiang1993 zouxiang1993 commented Mar 27, 2023

Which issue does this PR close?

Closes #770

Rationale for this change

What changes are included in this PR?

  • Change some query/disk_cache log level from info to debug

Are there any user-facing changes?

No

How does this change test

Existing CI

@codecov-commenter
Copy link

Codecov Report

Merging #776 (c6717f8) into main (32bd51e) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head c6717f8 differs from pull request most recent head 8d6a366. Consider uploading reports for the commit 8d6a366 to get more accurate results

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   68.47%   68.44%   -0.03%     
==========================================
  Files         296      296              
  Lines       46645    46645              
==========================================
- Hits        31938    31927      -11     
- Misses      14707    14718      +11     
Impacted Files Coverage Δ
components/object_store/src/disk_cache.rs 87.34% <0.00%> (ø)
analytic_engine/src/sst/parquet/async_reader.rs 90.48% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050
Copy link
Contributor

jiacai2050 commented Mar 28, 2023

@zouxiang1993 For your reference, I have modified your PR description to make it more readable for reviewers.

Anyway, thanks for contributing!

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 28, 2023
Merged via the queue into apache:main with commit 0117c23 Mar 28, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the logs for query
3 participants