Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove FixedSizeArena #772

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: remove FixedSizeArena #772

merged 1 commit into from
Mar 28, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #762

Rationale for this change

The FixedSizeArena is just a demo whose correctness and unit tests are missing, and it may make people confusing. So let's remove it.

What changes are included in this PR?

Remove the FixedSizeArena.

Are there any user-facing changes?

None.

How does this change test

No need to test.

@codecov-commenter
Copy link

Codecov Report

Merging #772 (36bd6e6) into main (50471c0) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 36bd6e6 differs from pull request most recent head 961a386. Consider uploading reports for the commit 961a386 to get more accurate results

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   68.48%   68.41%   -0.08%     
==========================================
  Files         296      295       -1     
  Lines       46648    46592      -56     
==========================================
- Hits        31947    31876      -71     
- Misses      14701    14716      +15     
Impacted Files Coverage Δ
components/arena/src/lib.rs 100.00% <ø> (ø)
analytic_engine/src/instance/read.rs 77.85% <100.00%> (-0.31%) ⬇️
analytic_engine/src/row_iter/mod.rs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 28, 2023
Merged via the queue into apache:main with commit c4cca73 Mar 28, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@ShiKaiWi ShiKaiWi deleted the fix-762 branch May 29, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question about FixedSizeArena's implementation
3 participants