Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move table engine proxy to table_engine crate #755

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Mar 22, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Now, rust-analyzer will report cyclic dependecy like:

[ERROR project_model::workspace] cyclic deps: server(CrateId(478)) -> interpreters(CrateId(256)), alternative path: interpreters(CrateId(256)) -> catalog_impls(CrateId(97)) -> server(CrateId(478))

We should fix it.

What changes are included in this PR?

Move table engine proxy to table_engine crate.

Are there any user-facing changes?

Rust-analyzer will not compare cyclic dependency now.

How does this change test

Test by ut.

@codecov-commenter
Copy link

Codecov Report

Merging #755 (307f3bb) into main (56bb7b0) will decrease coverage by 0.27%.
The diff coverage is 42.14%.

❗ Current head 307f3bb differs from pull request most recent head 7103d3e. Consider uploading reports for the commit 7103d3e to get more accurate results

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   68.43%   68.16%   -0.27%     
==========================================
  Files         294      296       +2     
  Lines       45712    46057     +345     
==========================================
+ Hits        31284    31396     +112     
- Misses      14428    14661     +233     
Impacted Files Coverage Δ
analytic_engine/src/instance/engine.rs 64.03% <ø> (ø)
analytic_engine/src/instance/mod.rs 83.33% <ø> (ø)
analytic_engine/src/sst/factory.rs 89.28% <ø> (ø)
analytic_engine/src/sst/writer.rs 92.85% <ø> (ø)
analytic_engine/src/table/partition.rs 0.00% <0.00%> (ø)
catalog_impls/src/table_based.rs 83.58% <ø> (ø)
components/parquet_ext/src/lib.rs 100.00% <ø> (ø)
router/src/lib.rs 9.09% <0.00%> (-40.91%) ⬇️
server/src/config.rs 37.20% <0.00%> (-0.44%) ⬇️
server/src/grpc/metrics.rs 0.00% <0.00%> (ø)
... and 44 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

server/src/handlers/influxdb.rs Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 22, 2023
@ShiKaiWi ShiKaiWi merged commit 99f2cf4 into apache:main Mar 22, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* move table engine proxy to table_engine crate.

* address CR.
@Rachelint Rachelint deleted the fix-cyclic-dependency branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants