feat: implement route cache #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
reviewed
Mar 17, 2023
chunshao90
reviewed
Mar 17, 2023
chunshao90
reviewed
Mar 18, 2023
chunshao90
reviewed
Mar 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #748 +/- ##
==========================================
- Coverage 68.49% 68.14% -0.35%
==========================================
Files 292 295 +3
Lines 45413 45776 +363
==========================================
+ Hits 31104 31195 +91
- Misses 14309 14581 +272
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ShiKaiWi
reviewed
Mar 21, 2023
ShiKaiWi
reviewed
Mar 21, 2023
ShiKaiWi
reviewed
Mar 21, 2023
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* impl route cache * add unit tests * route cache config serialize * did not reqeust to meta when no miss * chore * chore * fix unit test * fix dependency * sort dependency * update unit test * chore * change ttl data type * unimplemented instead todo * impl default * Update router/src/cluster_based.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * Update router/src/cluster_based.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * chore --------- Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #738
Rationale for this change
see #738
What changes are included in this PR?
add route cache
Are there any user-facing changes?
None
How does this change test
unit test