fix: start http server after table recovery finished #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
fix-server-panic
branch
from
96559f4
to
8484576
Compare
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 68.43% 68.45% +0.01%
==========================================
Files 294 292 -2
Lines 45712 45343 -369
==========================================
- Hits 31284 31040 -244
+ Misses 14428 14303 -125
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chunshao90
reviewed
Mar 16, 2023
jiacai2050
force-pushed
the
fix-server-panic
branch
from
363dfb5
to
be906f3
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* fix: start http server after table recovery finished * fix wrong error type * fix CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #559
Rationale for this change
If server start to serve request before table recovery finished, it may happen
panic in issue #559.
What changes are included in this PR?
Are there any user-facing changes?
No
How does this change test
CI and manually.