Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove compaction retry when memory limit #739

Merged
merged 21 commits into from
Mar 15, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Compaction retry immediately when memory limit, result in lots of logs will prints.

What changes are included in this PR?

  • remove compaction retry
  • modify log level to warn

Are there any user-facing changes?

None

How does this change test

None

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review March 15, 2023 08:37
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 15, 2023
Merged via the queue into apache:main with commit c59d9c3 Mar 15, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* support auto create config

* remove compaction retry

* add table name in log

* modify log

* continue to open shard when open table failed

* fmt

* romove unused lines

* Update server/src/grpc/meta_event_service/mod.rs

Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>

* add finsih log after open shard

* clippy

* return error when some tables failed to open

* add cost time

* log detail table error

* blank

* chore

* format log

* remove compaction retry when memory limit

---------

Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants