Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: div zero when compaction #734

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: div zero when compaction #734

merged 1 commit into from
Mar 15, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #729

Rationale for this change

Refer to #729

What changes are included in this PR?

  • Avoid being divided by zero.

Are there any user-facing changes?

None.

How does this change test

Add a tests for it.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #734 (9022d23) into main (c0494fe) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9022d23 differs from pull request most recent head dac7034. Consider uploading reports for the commit dac7034 to get more accurate results

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   68.47%   68.47%   -0.01%     
==========================================
  Files         294      294              
  Lines       45678    45684       +6     
==========================================
+ Hits        31278    31282       +4     
- Misses      14400    14402       +2     
Impacted Files Coverage Δ
analytic_engine/src/compaction/picker.rs 84.44% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@MichaelLeeHZ MichaelLeeHZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelLeeHZ MichaelLeeHZ added this pull request to the merge queue Mar 15, 2023
Merged via the queue into apache:main with commit db3a25a Mar 15, 2023
@ShiKaiWi ShiKaiWi deleted the fix-729 branch March 15, 2023 05:54
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread 'ceres-bg' panicked: 'attempt to divide by zero'
3 participants