Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support integration tests for influxql #719

Merged

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Mar 9, 2023

Which issue does this PR close?

Closes #716

Rationale for this change

Refer to #716 #698

What changes are included in this PR?

  • Support integration tests for InfluxQL;

Are there any user-facing changes?

How does this change test

@ShiKaiWi ShiKaiWi force-pushed the feat-support-integration-tests-for-influxql branch from 9345666 to be0e262 Compare March 9, 2023 10:35
Cargo.toml Outdated Show resolved Hide resolved
integration_tests/src/database.rs Outdated Show resolved Hide resolved
ShiKaiWi and others added 2 commits March 10, 2023 11:15
Co-authored-by: Jiacai Liu <dev@liujiacai.net>
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #719 (ab55ffb) into main (49fadb1) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head ab55ffb differs from pull request most recent head 113dce5. Consider uploading reports for the commit 113dce5 to get more accurate results

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   68.18%   68.12%   -0.06%     
==========================================
  Files         287      287              
  Lines       45124    45161      +37     
==========================================
+ Hits        30766    30767       +1     
- Misses      14358    14394      +36     
Impacted Files Coverage Δ
server/src/config.rs 37.64% <0.00%> (-0.45%) ⬇️
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/write.rs 37.32% <0.00%> (-1.67%) ⬇️
server/src/handlers/prom.rs 68.44% <0.00%> (+0.16%) ⬆️
server/src/server.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 self-requested a review March 10, 2023 06:04
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 10, 2023
Merged via the queue into apache:main with commit 11a3b5c Mar 10, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: support integration tests for influxql

* update the testcases for influxql

* update cargo.lock

* revert issue-302 test case

* Update Cargo.toml

Co-authored-by: Jiacai Liu <dev@liujiacai.net>

* address CR

* fix wrong usage of sqlness arg

---------

Co-authored-by: Jiacai Liu <dev@liujiacai.net>
@ShiKaiWi ShiKaiWi deleted the feat-support-integration-tests-for-influxql branch May 29, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for InfluxQL
4 participants