Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove cluster version #669

Merged
merged 10 commits into from
Mar 8, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Part of #663

Rationale for this change

Remove the useless cluster version in the WAL location, which is introduced by #442 to solve the problems mentioned in #441.

What changes are included in this PR?

Are there any user-facing changes?

None.

How does this change test

Existing tests.

@ShiKaiWi ShiKaiWi force-pushed the refactor-remove-cluster-version branch from 84509d1 to 8af6247 Compare February 27, 2023 07:15
@ShiKaiWi ShiKaiWi changed the title Refactor remove cluster version refactor: remove cluster version Feb 28, 2023
@ShiKaiWi ShiKaiWi force-pushed the refactor-remove-cluster-version branch from 2974503 to c9294f6 Compare March 6, 2023 08:07
@ShiKaiWi ShiKaiWi marked this pull request as ready for review March 6, 2023 12:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #669 (0933970) into main (f79890b) will decrease coverage by 0.09%.
The diff coverage is 39.89%.

❗ Current head 0933970 differs from pull request most recent head 39e571a. Consider uploading reports for the commit 39e571a to get more accurate results

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   67.55%   67.47%   -0.09%     
==========================================
  Files         281      282       +1     
  Lines       44343    44309      -34     
==========================================
- Hits        29956    29896      -60     
- Misses      14387    14413      +26     
Impacted Files Coverage Δ
analytic_engine/src/instance/close.rs 0.00% <ø> (ø)
analytic_engine/src/instance/open.rs 80.18% <ø> (-0.07%) ⬇️
analytic_engine/src/manifest/mod.rs 0.00% <ø> (ø)
server/src/grpc/meta_event_service/mod.rs 0.00% <0.00%> (ø)
...ver/src/grpc/meta_event_service/shard_operation.rs 0.00% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)
src/setup.rs 0.00% <0.00%> (ø)
wal/src/rocks_impl/manager.rs 91.12% <44.44%> (-1.41%) ⬇️
analytic_engine/src/setup.rs 56.04% <70.00%> (-0.27%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ShiKaiWi ShiKaiWi requested a review from Rachelint March 7, 2023 07:24
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Mar 8, 2023
Merged via the queue into apache:main with commit ac04659 Mar 8, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* refactor: remove version of region in WAL

* refactor: set up server

* refactor: setup procedure

* refactor: fix unit test

* chore: rename context to build context

* fix: avoid wal dropped when reopen

* chore: avoid useless config updating in ut

* fix: wrong config for test write buffer

* fix: implement close region for table-kv based wal

* chore: fix missing wals for no meta mode
@ShiKaiWi ShiKaiWi deleted the refactor-remove-cluster-version branch May 29, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants