-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support DataTypes of Date and Time #657
Conversation
# Conflicts: # common_types/src/datum.rs # proto/protos/common.proto
Codecov Report
@@ Coverage Diff @@
## main #657 +/- ##
==========================================
+ Coverage 66.94% 67.28% +0.34%
==========================================
Files 283 283
Lines 43969 44491 +522
==========================================
+ Hits 29435 29936 +501
- Misses 14534 14555 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…into feature_support_date
@MachaelLee I find the test coverage ratio of common_util/src/codec/memcomparable/datum.rs drops 5.5%. |
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
…into feature_support_date
…re_support_date_time # Conflicts: # common_types/src/datum.rs
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add date type * support date * suppport date * dev finish, ready to test * impl time * proto dependency * import specify proto * add some test * remove blank lines * remove blank lines * remove blank lines * fmt * add test case * fmt * addd test case * fmt * udpate ut * fix * fix * Update analytic_engine/src/table/data.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * fix * add some comment * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * support negative time * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * add some test * support time * test * support mysql time * format date time * add some test * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> * add some test * Update common_types/src/datum.rs Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> --------- Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Which issue does this PR close?
Closes #194
Rationale for this change
Support DataTypes of Date and Time
What changes are included in this PR?
Support DataTypes of Date and Time
Are there any user-facing changes?
Support DataTypes of Date and Time
How does this change test
Test with following sqls: