Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move proto to ceresdbproto repo #644

Merged
merged 3 commits into from
Feb 14, 2023
Merged

chore: move proto to ceresdbproto repo #644

merged 3 commits into from
Feb 14, 2023

Conversation

chunshao90
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Put the proto used by ceresdb in the ceresdbproto repo for management.

What changes are included in this PR?

Update the import path.

Are there any user-facing changes?

No.

How does this change test

No need.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #644 (da95497) into main (d906f9f) will increase coverage by 0.45%.
The diff coverage is 55.97%.

❗ Current head da95497 differs from pull request most recent head 9d00fbe. Consider uploading reports for the commit 9d00fbe to get more accurate results

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   66.44%   66.89%   +0.45%     
==========================================
  Files         283      282       -1     
  Lines       44286    43982     -304     
==========================================
- Hits        29424    29420       -4     
+ Misses      14862    14562     -300     
Impacted Files Coverage Δ
analytic_engine/src/sst/meta_data/mod.rs 24.19% <ø> (ø)
analytic_engine/src/sst/parquet/encoding.rs 95.42% <ø> (ø)
common_types/src/datum.rs 50.69% <ø> (ø)
common_types/src/projected_schema.rs 69.54% <0.00%> (-0.81%) ⬇️
common_util/src/config.rs 87.05% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <ø> (ø)
server/src/grpc/remote_engine_service/error.rs 0.00% <ø> (ø)
server/src/grpc/remote_engine_service/mod.rs 0.00% <ø> (ø)
system_catalog/src/sys_catalog_table.rs 92.20% <ø> (ø)
table_engine/src/engine.rs 54.28% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 added this pull request to the merge queue Feb 14, 2023
Merged via the queue into apache:main with commit 28be00e Feb 14, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: use proto in ceresdbproto

* cargo fmt

* refactor code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants