Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless code #630

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Feb 9, 2023

Which issue does this PR close?

Closes #

Rationale for this change

  • The role_table module seems useless now.
  • The wal synchronizer is useless now.

What changes are included in this PR?

  • Remove the role_table module.
  • Remove wal synchronizer.

Are there any user-facing changes?

Existing tests.

How does this change test

Existing tests.

@ShiKaiWi ShiKaiWi changed the title chore: remove role table module chore: remove useless code Feb 9, 2023
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 9, 2023
Merged via the queue into apache:main with commit 8b5e7d9 Feb 9, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: remove role table module

* remove wal synchronization
@ShiKaiWi ShiKaiWi deleted the remove-useless-code branch May 29, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants