Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify wal config #629

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #612

Rationale for this change

See issue above.

What changes are included in this PR?

See issue above.

Are there any user-facing changes?

None.

How does this change test

Test by ut.

@Rachelint Rachelint changed the title Modify wal config chore: modify wal config Feb 9, 2023
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 9, 2023
Merged via the queue into apache:main with commit 2819d5e Feb 9, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* move wal_path to RocksDBConfig and rename it to path.

* modify config.
@Rachelint Rachelint deleted the modify-wal-config branch May 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move config wal_path under RocksDB of WalStorageConfig
3 participants