Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary keys defaults to tsid, timestamp #621

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Feb 8, 2023

Which issue does this PR close?

Closes #

Rationale for this change

I find this bug when write docs https://github.com/CeresDB/docs/pull/25

Primary key already is tsid, timestamp by default in SQL, update grpc to follow this.

What changes are included in this PR?

Are there any user-facing changes?

No

How does this change test

UT

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 15e7314 into apache:main Feb 8, 2023
@jiacai2050 jiacai2050 deleted the fix-auto-create-table branch February 8, 2023 06:55
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* primary keys defaults to tsid, timestamp

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants