feat: make bloom filter optional on column level #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
changed the title
ShiKaiWi
added
feature
Codecov Report
@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 66.02% 66.02%
=======================================
Files 285 285
Lines 44358 44395 +37
=======================================
+ Hits 29288 29314 +26
- Misses 15070 15081 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jiacai2050
reviewed
Feb 6, 2023
jiacai2050
reviewed
Feb 6, 2023
jiacai2050
reviewed
Feb 6, 2023
jiacai2050
reviewed
Feb 6, 2023
jiacai2050
reviewed
Feb 6, 2023
jiacai2050
reviewed
Feb 7, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: make bloom filter optional in both row-group level and column level * make bloom-filter row_group level required * fix relative importing * add UT for conversion of BloomFilter * fix ut of conversion for bloom filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently, the bloom filter is only optional on file level, and the bloom filters on column level are still required. However, in some cases, a column bloom filter may be useless, which can be avoided after this PR.
And for compatibility, the version of bloom filter should be introduced.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Existing tests.