Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs #614

Merged
merged 3 commits into from
Feb 8, 2023
Merged

chore: add logs #614

merged 3 commits into from
Feb 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Feb 6, 2023

Which issue does this PR close?

Closes #

Rationale for this change

When troubleshooting in local my host, I found those logs are useful.

What changes are included in this PR?

Are there any user-facing changes?

No

How does this change test

This is what looks now

2023-02-06 16:07:24.514 INFO [server/src/http.rs:462] HTTP server starts listening on 127.0.0.1:5440
2023-02-06 16:07:24.515 INFO [server/src/server.rs:114] Server start, open local tables
2023-02-06 16:07:24.515 INFO [server/src/server.rs:128] Server start, create default schema if not exist
2023-02-06 16:07:24.516 INFO [server/src/server.rs:131] Server start, start services
2023-02-06 16:07:24.516 INFO [server/src/mysql/service.rs:54] MySQL server starts listening on 127.0.0.1:3307
2023-02-06 16:07:24.516 INFO [server/src/server.rs:138] Server start finished
2023-02-06 16:07:24.516 INFO [server/src/grpc/mod.rs:168] Grpc server starts listening on 127.0.0.1:8831
2023-02-06 16:07:24.517 INFO [server/src/grpc/mod.rs:177] Grpc server serves remote engine rpc service

server/src/mysql/service.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit d6f5e77 into apache:main Feb 8, 2023
@jiacai2050 jiacai2050 deleted the chore-log branch February 8, 2023 07:31
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: add logs

* fix reviews

* panic when listen failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants