Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print error in datanode #613

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Now error occured while handling meta's request isn't printed in datanode, that make trouble in debugging.

What changes are included in this PR?

Print error datanode before returning to meta.

Are there any user-facing changes?

None.

How does this change test

Test manually.

@codecov-commenter
Copy link

Codecov Report

Merging #613 (680a0b3) into main (6d57582) will increase coverage by 3.40%.
The diff coverage is n/a.

❗ Current head 680a0b3 differs from pull request most recent head ca6d129. Consider uploading reports for the commit ca6d129 to get more accurate results

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   62.61%   66.02%   +3.40%     
==========================================
  Files         326      285      -41     
  Lines       50232    44358    -5874     
==========================================
- Hits        31454    29286    -2168     
+ Misses      18778    15072    -3706     
Impacted Files Coverage Δ
server/src/grpc/meta_event_service/mod.rs 0.00% <ø> (ø)
server/src/grpc/storage_service/write.rs 38.99% <0.00%> (-3.67%) ⬇️
analytic_engine/src/sst/file.rs 76.17% <0.00%> (-1.09%) ⬇️
analytic_engine/src/instance/write_worker.rs 72.41% <0.00%> (-0.77%) ⬇️
analytic_engine/src/row_iter/merge.rs 88.58% <0.00%> (-0.19%) ⬇️
query_engine/src/context.rs 98.11% <0.00%> (-0.04%) ⬇️
server/src/http.rs 0.00% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)
sql/src/partition.rs 0.00% <0.00%> (ø)
server/src/handlers/sql.rs 0.00% <0.00%> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 3dfdc20 into apache:main Feb 6, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* print error in datanode.

* address CR.
@Rachelint Rachelint deleted the print-error-in-datanode branch May 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants