-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to Datafusion 17 #601
Conversation
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 66.01% 65.91% -0.11%
==========================================
Files 285 285
Lines 44358 44482 +124
==========================================
+ Hits 29285 29322 +37
- Misses 15073 15160 +87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -282,6 +284,10 @@ impl<'a, P: MetaProvider> ContextProvider for ContextProviderAdapter<'a, P> { | |||
) -> Option<common_types::schema::DataType> { | |||
None | |||
} | |||
|
|||
fn options(&self) -> &ConfigOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement this
let deadline = match state.config.config_options().get(CERESDB_REQUEST_TIMEOUT) { | ||
Some(ScalarValue::UInt64(Some(n))) => Some(Instant::now() + Duration::from_millis(n)), | ||
_ => None, | ||
let ceresdb_options = state.config_options().extensions.get::<CeresdbOptions>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This couldn't be None in our case, I think we can add an assert here.
assert!(options.is_some());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: upgrade to datafusion 17 * fix integration tests * fix integration test * make CI happy * refactor code * refactor by CR * chore: remove uesless file
Which issue does this PR close?
Closes #
Rationale for this change
Upgrade to datafusion 17 and arrow 31.
What changes are included in this PR?
Jobs left:
Changelog of those two packages:
https://github.com/apache/arrow-datafusion/blob/master/datafusion/CHANGELOG.md#1700-2023-01-27
https://github.com/apache/arrow-rs/blob/master/CHANGELOG-old.md#3100-2023-01-13
Are there any user-facing changes?
No.
How does this change test