Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid routing for non-existent table #551

Merged

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jan 9, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Auto picking a random node for non-existing table may leading to confusion to the router's user.

What changes are included in this PR?

  • Remove the logic for auto picking a random node for non-existent table;

Are there any user-facing changes?

Empty routing result will be returned for non-existent table.

How does this change test

Existing tests.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 6422cb0 into apache:main Jan 9, 2023
@ShiKaiWi ShiKaiWi deleted the fix-avoid-routing-for-non-exist-table branch January 9, 2023 12:29
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants