Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "feat: support bloom filter in hybrid format (#479)" #549

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix: Revert "feat: support bloom filter in hybrid format (#479)" #549

merged 1 commit into from
Jan 9, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jan 9, 2023 •
edited
Loading

Which issue does this PR close?

Closes #

Rationale for this change

After #479, sst file size is larger than before, so revert this commit

$ du -sh data-with-flush/store/2 data-without-flush/store/2
371M    data-with-flush/store/2
328M    data-without-flush/store/2

What changes are included in this PR?

Are there any user-facing changes?

No

How does this change test

Existing UT

@jiacai2050 jiacai2050 changed the title Revert "feat: support bloom filter in hybrid format (#479)" fix: Revert "feat: support bloom filter in hybrid format (#479)" Jan 9, 2023
chunshao90
chunshao90 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 8e53951 into apache:main Jan 9, 2023
@jiacai2050 jiacai2050 deleted the fix-hybrid branch January 9, 2023 12:28
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
Revert "feat: support bloom filter in hybrid format (apache#479)" (ap…
3f6b279 
…ache#549)

This reverts commit eee0612.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

@Rachelint Rachelint Awaiting requested review from Rachelint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @chunshao90