fix: fix conversion by avro #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
fix-convertion-by-avro
branch
2 times, most recently
from
6da2d76
to
0643817
Compare
Rachelint
force-pushed
the
fix-convertion-by-avro
branch
from
0643817
to
f2818bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Part of #492
Rationale for this change
We convert all
intrelated types toint32andint64, because only these two int types inavronow.So when converting
Value(avrodatum) toDatum, we should convert it back to the right type in schema.What changes are included in this PR?
Modify
avro_value_to_datuminavro.rsfor converting back to the right type.Are there any user-facing changes?
None.
How does this change test
Test by ut.