feat: update ceresdb proto & adapter to partition info #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
reviewed
Dec 27, 2022
chunshao90
changed the title
chunshao90
reviewed
Dec 27, 2022
There was a problem hiding this comment.
Partition info needs to be set. https://github.com/CeresDB/ceresdb/blob/main/server/src/grpc/meta_event_service/mod.rs#L347
Rachelint
reviewed
Dec 28, 2022
chunshao90
reviewed
Dec 29, 2022
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* update ceresdb proto & adapter to partition info * refactor by cr * fix CI * refactor by cr * add encoder test Co-authored-by: jiacai2050 <dev@liujiacai.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
To support creation of partition tables, we have updated the data structure in ceresdbproto and added encodedPartitionInfo. CeresDB needs to adapt to this adjustment.
What changes are included in this PR?
meta_updateto decode/encode oneof struct.Are there any user-facing changes?
None.
How does this change test
Pass exists unit tests.