feat: scan row groups in one sst file parallelly #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
from
fc26b39
to
a4f2a39
Compare
chunshao90
reviewed
Dec 12, 2022
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
5 times, most recently
from
27fafff
to
33bb9e6
Compare
jiacai2050
reviewed
Dec 14, 2022
jiacai2050
requested changes
Dec 14, 2022
jiacai2050
requested changes
Dec 15, 2022
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
2 times, most recently
from
5c75795
to
75f6e5e
Compare
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
2 times, most recently
from
e40ba49
to
67823b4
Compare
chunshao90
reviewed
Dec 15, 2022
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
3 times, most recently
from
3f51d14
to
a925730
Compare
jiacai2050
reviewed
Dec 16, 2022
jiacai2050
reviewed
Dec 16, 2022
jiacai2050
reviewed
Dec 16, 2022
jiacai2050
reviewed
Dec 16, 2022
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
from
a925730
to
7a81423
Compare
jiacai2050
reviewed
Dec 16, 2022
Rachelint
force-pushed
the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
from
7a81423
to
ea76811
Compare
jiacai2050
changed the title
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* make scanning sst file in parallel. * rename `read_parallelism` to `background_read_parallelism` in `SstReaderOptions`. * address CR. * fix parallelly reading but and add tests. * add more checks for the `read_parallism`. * address CR.
Rachelint
deleted the
origin/make-pulling-single-sst-file-in-row-group-parallel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Now, the concurrent level while pulling sst data is on file level, we can enhance it to row group level.
What changes are included in this PR?
Are there any user-facing changes?
How does this change test
Test by ut.