Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pgwire to 0.19 #1436

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Jan 11, 2024

Rationale

pgwire author here. This patch updates pgwire to 0.19 which contains compatibility fixes and API improvements.

Detailed Changes

Test Plan

Pass CI

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@ShiKaiWi
Copy link
Member

The style check failure is caused by upgrade of chrono. I guess we can only upgrade pgwire. Let me fix it.

@sunng87
Copy link
Contributor Author

sunng87 commented Jan 11, 2024

By the way, I'm having trouble with compiling librocksdb-sys on my archlinux:

  --- stderr
     Entering             /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/third-party/gtest-1.8.1/fused-src/gtest
     Called from: [1]	/home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/CMakeLists.txt
     Returning to         /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb
     Called from: [1]	/home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/CMakeLists.txt
     Entering             /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/tools
     Called from: [1]	/home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/CMakeLists.txt
     Returning to         /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb
     Called from: [1]	/home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/CMakeLists.txt
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc: In member function ‘virtual rocksdb::Status rocksdb::DBImpl::FlushWAL(bool)’:
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1349:23: error: redundant move in return statement [-Werror=redundant-move]
   1349 |       return std::move(io_s);
        |              ~~~~~~~~~^~~~~~
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1349:23: note: remove ‘std::move’ call
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1353:23: error: redundant move in return statement [-Werror=redundant-move]
   1353 |       return std::move(io_s);
        |              ~~~~~~~~~^~~~~~
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1353:23: note: remove ‘std::move’ call
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc: In member function ‘virtual rocksdb::Status rocksdb::DBImpl::LockWAL()’:
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1470:19: error: redundant move in return statement [-Werror=redundant-move]
   1470 |   return std::move(status);
        |          ~~~~~~~~~^~~~~~~~
  /home/sunng/.cargo/git/checkouts/rust-rocksdb-a9a28e74c6ead8ef/f04f4dd/librocksdb_sys/rocksdb/db/db_impl/db_impl.cc:1470:19: note: remove ‘std::move’ call
  cc1plus: all warnings being treated as errors
  make[3]: *** [CMakeFiles/rocksdb.dir/build.make:555: CMakeFiles/rocksdb.dir/db/db_impl/db_impl.cc.o] Error 1
  make[3]: *** Waiting for unfinished jobs....
  make[2]: *** [CMakeFiles/Makefile2:142: CMakeFiles/rocksdb.dir/all] Error 2
  make[1]: *** [CMakeFiles/Makefile2:149: CMakeFiles/rocksdb.dir/rule] Error 2
  make: *** [Makefile:172: rocksdb] Error 2
  thread 'main' panicked at /home/sunng/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 2

  build script failed, must exit now
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Is librocksdb-sys a required dependency? I wonder if there is any way to skip it.

@jiacai2050
Copy link
Contributor

Is librocksdb-sys a required dependency?

make build-wal-table-kv

It will build without rocksdb.

@ShiKaiWi
Copy link
Member

The style check failure is caused by upgrade of chrono. I guess we can only upgrade pgwire. Let me fix it.

It seems impossible to only upgrade pgwire. The deprecated method is replaced with the right one.

@ShiKaiWi
Copy link
Member

@sunng87 The CI has passed. Thanks.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 4b8e23e into apache:main Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants