Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_ranges is not spawned in io-runtime #1426

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jan 4, 2024

Rationale

The get_ranges should be executed in the io-runtime, but it is not now.

Detailed Changes

Spawn the get_ranges task in the io-runtime.

Test Plan

Should pass the CI.

@ShiKaiWi ShiKaiWi force-pushed the fix-io-runtime-for-get-ranges branch from 36e9b39 to cb7fc2b Compare January 9, 2024 12:06
@ShiKaiWi ShiKaiWi changed the base branch from dev to main January 11, 2024 03:02
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 3bcf037 into apache:main Jan 11, 2024
6 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-io-runtime-for-get-ranges branch January 22, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants