fix: skip wal encoding when data wal is disabled #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
reviewed
Dec 25, 2023
| encode_ctx.encode(&self.instance.wal_encode, &schema)? | ||
| }; | ||
| let seq = if self.instance.disable_wal { | ||
| MIN_SEQUENCE_NUMBER |
There was a problem hiding this comment.
The real sequence number should be returned, otherwise the merge procedure may not work with the mock one.
jiacai2050
force-pushed
the
fix-disable-wal
branch
3 times, most recently
from
e64719c
to
815c008
Compare
jiacai2050
force-pushed
the
fix-disable-wal
branch
from
815c008
to
6f0a540
Compare
ShiKaiWi
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When data wal is disable, data is still encoded, which waste cpu usage.
Detailed Changes
Skip encode when data wal is disabled.
Test Plan
CI.