Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing and verbose logs #1398

Merged
merged 1 commit into from
Dec 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion analytic_engine/src/instance/open.rs
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,13 @@ impl ShardOpener {
space,
})
}
Ok(None) => *state = TableOpenStage::Success(None),
Ok(None) => {
error!(
"ShardOpener trie to open a dropped table, table:{:?}, shard_id:{}",
ctx.table_def, self.shard_id
);
*state = TableOpenStage::Success(None);
}
Err(e) => *state = TableOpenStage::Failed(e),
}
}
Expand Down
4 changes: 2 additions & 2 deletions analytic_engine/src/manifest/details.rs
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ impl Manifest for ManifestImpl {
snapshot_store,
};
let meta_snapshot_opt = recover.recover().await?.and_then(|v| v.data);

let meta_snapshot_exists = meta_snapshot_opt.is_some();
// Apply it to table.
if let Some(snapshot) = meta_snapshot_opt {
let meta_edit = MetaEdit::Snapshot(snapshot);
Expand All @@ -552,7 +552,7 @@ impl Manifest for ManifestImpl {
self.table_meta_set.apply_edit_to_table(request)?;
}

info!("Manifest recover finish, request:{load_req:?}");
info!("Manifest recover finish, request:{load_req:?}, meta_snapshot_exist:{meta_snapshot_exists}");

Ok(())
}
Expand Down
10 changes: 5 additions & 5 deletions query_engine/src/datafusion_impl/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use std::{sync::Arc, time::Instant};

use async_trait::async_trait;
use generic_error::BoxError;
use logger::info;
use logger::debug;
use snafu::ResultExt;
use table_engine::stream::SendableRecordBatchStream;
use time_ext::InstantExt;
Expand Down Expand Up @@ -70,8 +70,8 @@ impl Executor for DatafusionExecutorImpl {
ctx: &Context,
physical_plan: PhysicalPlanPtr,
) -> Result<SendableRecordBatchStream> {
info!(
"DatafusionExecutorImpl begin to execute plan, request_id:{}, physical_plan: {:?}",
debug!(
"DatafusionExecutorImpl begin to execute plan, request_id:{}, physical_plan:{:?}",
ctx.request_id, physical_plan
);

Expand All @@ -87,8 +87,8 @@ impl Executor for DatafusionExecutorImpl {
msg: Some("failed to execute physical plan".to_string()),
})?;

info!(
"DatafusionExecutorImpl finish to execute plan, request_id:{}, cost:{}ms, plan_and_metrics: {}",
debug!(
"DatafusionExecutorImpl finish to execute plan, request_id:{}, cost:{}ms, plan_and_metrics:{}",
ctx.request_id,
begin_instant.saturating_elapsed().as_millis(),
physical_plan.metrics_to_string()
Expand Down
4 changes: 2 additions & 2 deletions query_engine/src/datafusion_impl/physical_plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use datafusion::physical_plan::{
ExecutionPlan,
};
use generic_error::BoxError;
use logger::info;
use logger::debug;
use snafu::{OptionExt, ResultExt};
use table_engine::stream::{FromDfStream, SendableRecordBatchStream};

Expand Down Expand Up @@ -109,7 +109,7 @@ impl PhysicalPlan for DataFusionPhysicalPlanAdapter {
Arc::new(CoalescePartitionsExec::new(executable))
};

info!(
debug!(
"DatafusionExecutorImpl get the executable plan, request_id:{}, physical_plan:{}",
df_task_ctx.ctx.request_id,
displayable(executable.as_ref()).indent(true)
Expand Down
Loading