Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid building dictionary for massive unique column values #1365

Merged
merged 6 commits into from
Dec 18, 2023
Merged

feat: avoid building dictionary for massive unique column values #1365

merged 6 commits into from
Dec 18, 2023

Conversation

ShiKaiWi
Copy link
Member

Rationale

Close #1105

Detailed Changes

  • Reduce the parameters in the sst write path
  • Avoid building dictionary for massive unique column values

Test Plan

  • New unit test for the changeset
  • Observe the metrics for disable/enable dictionary encoding

jiacai2050
jiacai2050 reviewed Dec 13, 2023
View reviewed changes
analytic_engine/Cargo.toml Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/writer.rs Show resolved Hide resolved
jiacai2050
jiacai2050 reviewed Dec 15, 2023
View reviewed changes
analytic_engine/src/sst/parquet/writer.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/writer.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/factory.rs Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi mentioned this pull request Dec 18, 2023
Closed
10 tasks
jiacai2050
jiacai2050 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 785eed7 into apache:dev Dec 18, 2023
7 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-abuse-parquet-dict branch December 18, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiKaiWi @jiacai2050