fix: dist query dedup #1269
Merged
fix: dist query dedup #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll them in `ExecutableScanBuilderImpl`. It is just a quick way to fix dedup, we should modify protobuf for solving it better in later.
Rachelint
force-pushed
the
fix-dist-query-dedup
branch
from
3777825
to
f3135e2
Compare
ShiKaiWi
reviewed
Oct 25, 2023
ShiKaiWi
approved these changes
Oct 26, 2023
|
@Rachelint Integration test fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We place some dynamic fields in plans needed to send for remote execution, that lead to failure of request dedup.
I make a quick fix in this pr by overwriting such fields before encoding, and refill them in remote.
Detailed Changes
ReadRequestinResovler.ExecutableScanBuilderImpl.Test Plan
Test by ut.