-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opentsdb api support gzip body #1261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
pushed a commit
that referenced
this pull request
Oct 16, 2023
## Rationale Due to the huge cache of rust before, unit tests often failed due to insufficient capacity. [CI without cache](https://github.com/CeresDB/ceresdb/actions/runs/6492219953/job/17630769103?pr=1259) takes an acceptable time and does not cause failure problems. #1261 show CI always fail in Rust Cache. The github action's time seems have huge volatile, https://github.com/CeresDB/ceresdb/actions/runs/6517181839/job/17701414760?pr=1259 takes 24 min without cache, some pr have cache even is slower than this action ## Detailed Changes Delete out the configuration related to github cache ## Test Plan CI
jiacai2050
requested changes
Oct 16, 2023
jiacai2050
reviewed
Oct 16, 2023
jiacai2050
reviewed
Oct 16, 2023
jiacai2050
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
telegraf use gzip body to write opentsdb, so we will need to support to ungzip the body
TODO: telegraf output double's zero as
0
, which will confuse ceresdb's auto create table, so we need diable auto create table in opentsdb api.Detailed Changes
support ungzip in http api
Test Plan
manaul