Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid flush when drop table #1257

Merged
merged 5 commits into from
Oct 16, 2023
Merged

feat: avoid flush when drop table #1257

merged 5 commits into from
Oct 16, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

When drop a table, flush is unnecessary, and this cause the drop take a long time.

Detailed Changes

Mark WAL as deleted directly when drop table.

Test Plan

Manually

@jiacai2050 jiacai2050 changed the title feat: drop table should not do flush feat: avoid flush when drop table Oct 11, 2023
Rachelint
Rachelint approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit ad70bc1 into apache:main Oct 16, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the feat-drop branch October 16, 2023 03:03
@jiacai2050 jiacai2050 mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiacai2050 @ShiKaiWi @Rachelint