Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disk cache deduped get_ranges #1218

Merged
merged 5 commits into from
Sep 21, 2023
Merged

fix: disk cache deduped get_ranges #1218

merged 5 commits into from
Sep 21, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Sep 15, 2023 •
edited
Loading

Rationale

Close #1215

Detailed Changes

  • Add MemoryStore to help test
  • When persist file, first write to tmp file, then rename to dest file.

Test Plan

CI itself

@jiacai2050 jiacai2050 merged commit 41f6313 into apache:main Sep 21, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the fix-duped-get-range branch September 21, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang left review comments

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error getting data from disk cache in concurrent situation
3 participants
@jiacai2050 @ShiKaiWi @tanruixiang