Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lock contention on acquiring the arena stats #1207

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: lock contention on acquiring the arena stats #1207

merged 1 commit into from
Sep 11, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Sep 11, 2023 •
edited
Loading

Rationale

There is no need to acquire the write lock when fetch arena's stats.

Detailed Changes

Use RwLock instead of Mutex to protect the core of the MonoIncArena to avoid lock contention.

Test Plan

Existing tests.

jiacai2050
jiacai2050 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit cfaa105 into apache:main Sep 11, 2023
6 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-rwlock-for-arena-stats branch September 11, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiKaiWi @jiacai2050