Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic when read data out of range by disk cache #1206

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix: panic when read data out of range by disk cache #1206

merged 2 commits into from
Sep 11, 2023

Conversation

ShiKaiWi
Copy link
Member

Rationale

Close #1194

Detailed Changes

Throw OutOfRange error when the query range is out of the file size.

Test Plan

Add a new dedicated unit test for this case.

jiacai2050
jiacai2050 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit be97733 into apache:main Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compaction panic when read disk cache
2 participants
@ShiKaiWi @jiacai2050