Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logic of keep scheduling compaction #1113

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: logic of keep scheduling compaction #1113

merged 1 commit into from
Jul 28, 2023

Conversation

baojinri
Copy link
Contributor

Rationale

See title

Detailed Changes

  • Remove ! in logic of keep scheduling compaction

Test Plan

  • Existing tests
  • mannually tests

jiacai2050
jiacai2050 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 1a47fd9 into apache:main Jul 28, 2023
5 checks passed
@baojinri baojinri mentioned this pull request Jul 28, 2023
Closed
@baojinri baojinri deleted the fix-concurrently-compact branch December 5, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baojinri @jiacai2050