Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused codes about the page index #1111

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: remove unused codes about the page index #1111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions analytic_engine/src/sst/parquet/async_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,19 +363,7 @@ impl<'a> Reader<'a> {
file_path: self.path.to_string(),
})?;

// TODO: reopen following code until https://github.com/CeresDB/ceresdb/issues/1040 is fixed
// let object_store_reader = parquet_ext::reader::ObjectStoreReader::new(
// self.store.clone(),
// self.path.clone(),
// Arc::new(parquet_meta_data),
// );

// let parquet_meta_data =
// parquet_ext::meta_data::meta_with_page_indexes(object_store_reader)
// .await
// .with_context(|| DecodePageIndexes {
// file_path: self.path.to_string(),
// })?;
// TODO: Support page index until https://github.com/CeresDB/ceresdb/issues/1040 is fixed.

MetaData::try_new(&parquet_meta_data, ignore_sst_filter)
.box_err()
Expand Down
Loading