feat: use manifest updates stats in TableData to trigger snapshot
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
TableData to trigger snapshotTableData to trigger snapshot
Rachelint
changed the title
TableData to trigger snapshotTableData to trigger snapshot
Rachelint
force-pushed
the
refactor-manifest-snapshot
branch
from
0f439cd
to
8be698a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now we stats manifest updates of all tables in
Manifestto trigger snapshot.However when snapshot is triggered, it will just do snapshot of latest table storing update.
It is obvious unreasonable...
Worse, this mechanism lead to bug #1075 ...
So In this pr, I place the manifest updates stats into
TableData, and each table can only trigger snapshot of itself rather than others.Detailed Changes
TableData.Test Plan
Test by new ut.