Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make is_dictionary optional #1074

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix: make is_dictionary optional #1074

merged 3 commits into from
Jul 13, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

We support tag to be dictionary encoding, but in a back-incompatible way, it will throw following errors:

err:Arrow field meta key is not found, key:IsDictionary.

Detailed Changes

  • When parse arrow meta, make is_dictionary optional

Test Plan

UT

@tanruixiang tanruixiang changed the title fix: make is_dictionary optional fix: make is_dictionary optional Jul 13, 2023
chunshao90
chunshao90 reviewed Jul 13, 2023
View reviewed changes
common_types/src/column_schema.rs Outdated Show resolved Hide resolved
common_types/src/column_schema.rs Outdated Show resolved Hide resolved
chunshao90
chunshao90 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 4625bde into apache:main Jul 13, 2023
@jiacai2050 jiacai2050 deleted the fix-dict-meta branch July 13, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang left review comments

@chunshao90 chunshao90 chunshao90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiacai2050 @chunshao90 @tanruixiang