Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support query opened shards info #1070

Merged
merged 4 commits into from
Jul 13, 2023
Merged

feat: support query opened shards info #1070

merged 4 commits into from
Jul 13, 2023

Conversation

baojinri
Copy link
Contributor

Rationale

Close #1066

Detailed Changes

  • Add cluster in http server
  • Add list shards in cluster trait
  • Add query api in http server

Test Plan

  • Existing tests
  • Manually tests

ShiKaiWi
ShiKaiWi reviewed Jul 12, 2023
View reviewed changes
server/src/http.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi reviewed Jul 13, 2023
View reviewed changes
server/src/http.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit de34729 into apache:main Jul 13, 2023
@baojinri baojinri deleted the feat-support-query-open-shard-info branch December 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add /debug/shards API
3 participants
@baojinri @jiacai2050 @ShiKaiWi