feat: avoid prefetching all sst streams at once #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
feat-control-pull-record-batches
branch
from
ee14206
to
568e135
Compare
Rachelint
reviewed
Jul 14, 2023
ShiKaiWi
force-pushed
the
feat-control-pull-record-batches
branch
from
2a6e6c7
to
32ac0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #959
The current procedure to fetch sst data is started immediately, and it may lead to high memory consumption when massive concurrent queries reaches.
Detailed Changes
Introduce a prefetchable stream to replace the normal stream, with which a way to trigger the fetching data is provided and when to trigger it can also be determined by the caller.
Test Plan
The memory usage and latency of the old version and new one will be attached here.