chore: cherry pick related prs to release-1.2.3 #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1fd7857.
## Rationale In the old kafka logs deletion and recovery logic, some conercases leading to logs can never be cleaned up. ## Detailed Changes - Fix the logs deletion logic. - Fix recovery logic. ## Test Plan Test manually.
…ions of `Shard` (apache#1056) ## Rationale Close apache#1053 Now, write operations for shard will be performed parallelly in ceresdb node(e.g. recover, alter tables in shard). Obviously, those operations should be performed sequentially like what about table. ## Detailed Changes + introduce `Shard` like `Table`. + make write operations for shard performing sequentially by adding a mutex. ## Test Plan Test manually.
## Rationale Now when opening a fully flushed region, it may hang forever... This pr fix this problem on wal level, but it is the problem in kafka client that is planned to fix in later. ## Detailed Changes See title. ## Test Plan Test manually.
## Rationale Now it will still scan logs from wal when no table datas needed to replay, it should directly return actually. ## Detailed Changes Add a fast path to return directly when no table datas needed to replay. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Cherry pick recovery related prs to release-1.2.3.
Detailed Changes
Cherry pick recovery related prs to release-1.2.3.
Test Plan
Has tested in main branch.