Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use varint to encode string/bytes length #1060

Merged
merged 4 commits into from
Jul 11, 2023
Merged

refactor: use varint to encode string/bytes length #1060

merged 4 commits into from
Jul 11, 2023

Conversation

baojinri
Copy link
Contributor

Rationale

close #1055

Detailed Changes

  • use varint to encode length of string/bytes in memtable

Test Plan

  • Existing tests

ShiKaiWi
ShiKaiWi reviewed Jul 10, 2023
View reviewed changes
common_types/src/row/contiguous.rs Outdated Show resolved Hide resolved
common_types/src/row/contiguous.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 8afb0b1 into apache:main Jul 11, 2023
@baojinri baojinri deleted the feat-use-varint-encode-length branch December 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use varint to encode string/bytes length in memtable
2 participants
@baojinri @ShiKaiWi