feat: expose more rocksdb options #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
reviewed
Jun 26, 2023
ShiKaiWi
reviewed
Jun 26, 2023
zouxiang1993
changed the title
ShiKaiWi
reviewed
Jun 27, 2023
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
zouxiang1993
force-pushed
the
expose-more-rocksdb-options
branch
from
4839599
to
989b419
Compare
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale Now rocksdb as the wal, it is easy to become the bottleneck of write. ## Detailed Changes 1. expose more rocksdb options to avoid write stall 2. introduce rocksdb's FIFO compaction style, which makes rocksdb looks like a message queue. (FIFO is more suitable for time-series data, maybe it will become the default option in the future.) ## Test Plan I will test it in my test env. --------- Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now rocksdb as the wal, it is easy to become the bottleneck of write.
Detailed Changes
(FIFO is more suitable for time-series data, maybe it will become the default option in the future?)
Test Plan
I will test it in my test env.