fix: arrow meta data is lost when decode custom meta data #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
fix-missing-arrow-meta-data
branch
from
5b34c04
to
cfb9bfb
Compare
tanruixiang
reviewed
Jun 19, 2023
|
LGTM |
tanruixiang
approved these changes
Jun 19, 2023
MichaelLeeHZ
pushed a commit
to MichaelLeeHZ/ceresdb
that referenced
this pull request
Jun 21, 2023
The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. Keep the other metadata in the parquet metadata after extracting our custom metadata. Add unit test `test_arrow_meta_data` for it.
tanruixiang
pushed a commit
to tanruixiang/incubator-horaedb
that referenced
this pull request
Jun 25, 2023
The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. Keep the other metadata in the parquet metadata after extracting our custom metadata. Add unit test `test_arrow_meta_data` for it.
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
Jun 25, 2023
The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. Keep the other metadata in the parquet metadata after extracting our custom metadata. Add unit test `test_arrow_meta_data` for it.
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. ## Detailed Changes Keep the other metadata in the parquet metadata after extracting our custom metadata. ## Test Plan Add unit test `test_arrow_meta_data` for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata.
Detailed Changes
Keep the other metadata in the parquet metadata after extracting our custom metadata.
Test Plan
Add unit test
test_arrow_meta_datafor it.