Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the readability of error messages #1386

Closed
ZuLiangWang opened this issue Dec 21, 2023 · 2 comments
Closed

Improve the readability of error messages #1386

ZuLiangWang opened this issue Dec 21, 2023 · 2 comments
Labels
feature New feature or request

Comments

@ZuLiangWang
Copy link
Contributor

Describe This Problem

Currently, the error information in HoraeDB is unclear (for example, In many cases, users will see the error table not found.). When an error occurs, it confuses users and increases the difficulty of troubleshooting and locating problems.

Proposal

Make error messages clearer, classify error messages, and even consider designing error codes to classify error messages in the form of error codes.

Additional Context

No response
@ZuLiangWang ZuLiangWang added the feature New feature or request label Dec 21, 2023
@tanruixiang
Copy link
Member

May be we can make a example and split tasks into modules and track them. cc @ShiKaiWi

@ZuLiangWang ZuLiangWang mentioned this issue Jan 3, 2024
Merged
jiacai2050 pushed a commit that referenced this issue Jan 8, 2024
@ZuLiangWang
feat: add table status check (#1418)
dc10253 
## Rationale
Refer to this issue
#1386, currently, if
the status of the shard is abnormal, we cannot get any valid exception
information from the error message `table not found`.

## Detailed Changes
* Add `TableStatus` in `cluster`, you can use it to get the status of
the table in the current cluster..
* Add `SchemaWithCluster`, It wraps the schema inside the cluster,
through which the state of the cluster and schema can be combined.

## Test Plan
Pass CI.
@jiacai2050
Copy link
Contributor

Fixed in #1418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiacai2050 @ZuLiangWang @tanruixiang